[RORDEV-1152] Compile modules test-utils and integration-tests with Scala 3.3.3 #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mgoworko
force-pushed
the
compile-tests-with-scala3
branch
from
5e0df81 to
9178f46
Compare
coutoPL
requested changes
Apr 8, 2024
Collaborator
coutoPL
left a comment
coutoPL
left a comment
There was a problem hiding this comment.
please merge the current develop branch
integration-tests/src/test/scala/tech/beshu/ror/integration/utils/ESVersionSupport.scala
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/containers/EsClusterContainer.scala
Show resolved
Hide resolved
tests-utils/src/main/scala/tech/beshu/ror/utils/misc/EsStartupChecker.scala
Outdated
Show resolved
Hide resolved
mgoworko
force-pushed
the
compile-tests-with-scala3
branch
from
2d3e418 to
9178f46
Compare
…-scala3 # Conflicts: # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/AdminApiAuthMockSuite.scala # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/AdminApiWithDefaultRorIndexSuite.scala # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/ClusterApiSuite.scala # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/FipsSslSuite.scala # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/IndexLifecycleManagementApiSuite.scala # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/JwtAuthSuite.scala # integration-tests/src/test/scala/tech/beshu/ror/integration/suites/base/XpackClusterWithRorNodesAndInternodeSslSuite.scala
coutoPL
approved these changes
Apr 8, 2024
Collaborator
coutoPL
left a comment
coutoPL
left a comment
There was a problem hiding this comment.
Great! LGTM
Let me prepare the epic branch for the scala 3 migration and we are ready to merge
coutoPL
changed the title
coutoPL
changed the title
coutoPL
changed the base branch from
develop
to
epic/RORDEV-1152_scala3_migration
coutoPL
pushed a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules test-utils and integrations-tests are now compiled with Scala 3 (v3.3.3 LTS). Library upgrades and minor code adjustments.