Skip to content

[RORDEV-1453] Ubuntu apt-get based installation of ES in tests #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mgoworko
Copy link
Collaborator

@mgoworko mgoworko commented Jun 8, 2025

Summary by CodeRabbit

  • New Features

    • Added support for running and testing Elasticsearch containers installed via Ubuntu apt as an alternative to the official Docker image.
    • Introduced the ability to specify and handle different Elasticsearch installation types in container management utilities.
    • Added new utilities for capturing and combining Docker container logs during tests.
  • Improvements

    • Enhanced configuration flexibility for Elasticsearch containers, including dynamic command and configuration directory handling based on installation type.
    • Expanded version-matching patterns for Elasticsearch modules to improve test coverage and granularity.
    • Streamlined integration test execution in the CI pipeline.
    • Extended container creation APIs to optionally accept additional log consumers for enhanced log handling during tests.
    • Improved Docker image building by supporting setting CMD instructions from image descriptions.
  • Bug Fixes

    • Ensured correct log consumer handling and user context switching during container setup for improved reliability in tests.
  • Tests

    • Introduced a new test suite to verify ReadonlyREST plugin behavior across different Elasticsearch installation methods and versions.

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@sscarduzio
Copy link
Owner

little warning that I'm not sure if still valid: deb images were not available as soon as the archives in the past. It was a delayed thing. #TODO check if it's still the case

Repository owner deleted a comment from coderabbitai bot Jun 18, 2025
@mgoworko mgoworko changed the title In progress - [RORDEV-1453] Ubuntu apt-get based installation of ES in tests [RORDEV-1453] Ubuntu apt-get based installation of ES in tests Jun 18, 2025
@mgoworko mgoworko requested a review from coutoPL June 18, 2025 15:41
coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as outdated.

@mgoworko mgoworko requested a review from coutoPL July 5, 2025 09:49
Copy link
Collaborator

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Some minor comments

@mgoworko mgoworko merged commit f16a3ea into sscarduzio:develop Jul 8, 2025
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants