Changed the default value for includeInactive to be true, because of …

…reasons discussed in issue #275
ssannandeji · Jun 5, 2018 · 06b01e1 · 06b01e1
1 parent dde5244
commit 06b01e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/...ts/Plugins/Zenject/Source/Binding/Binders/Factory/FactoryFromBinder/FactoryFromBinder0.cs b/...ts/Plugins/Zenject/Source/Binding/Binders/Factory/FactoryFromBinder/FactoryFromBinder0.cs
@@ -75,7 +75,7 @@ public FactorySubContainerBinder<TContract> FromSubContainerResolve(object subId
 #if !NOT_UNITY3D
 
         public ConditionCopyNonLazyBinder FromComponentInHierarchy(
-            bool includeInactive = false)
+            bool includeInactive = true)
         {
             BindingUtil.AssertIsInterfaceOrComponent(ContractType);
 

diff --git a/UnityProject/Assets/Plugins/Zenject/Source/Binding/Binders/FromBinders/FromBinderGeneric.cs b/UnityProject/Assets/Plugins/Zenject/Source/Binding/Binders/FromBinders/FromBinderGeneric.cs
@@ -85,7 +85,7 @@ public ScopeConditionCopyNonLazyBinder FromInstance(TContract instance)
 
 #if !NOT_UNITY3D
 
-        public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool includeInactive = false)
+        public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool includeInactive = true)
         {
             BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);
 
@@ -104,13 +104,13 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInChildren(bool
         }
 
         public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInChildren(
-            Func<TContract, bool> predicate, bool includeInactive = false)
+            Func<TContract, bool> predicate, bool includeInactive = true)
         {
             return FromComponentsInChildren(false, predicate, includeInactive);
         }
 
         public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInChildren(
-            bool excludeSelf = false, Func<TContract, bool> predicate = null, bool includeInactive = false)
+            bool excludeSelf = false, Func<TContract, bool> predicate = null, bool includeInactive = true)
         {
             BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);
 
@@ -137,7 +137,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInChildren(
         }
 
         public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInParents(
-            bool excludeSelf = false, bool includeInactive = false)
+            bool excludeSelf = false, bool includeInactive = true)
         {
             BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);
 
@@ -164,7 +164,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInParents(
         }
 
         public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInParents(
-            bool excludeSelf = false, bool includeInactive = false)
+            bool excludeSelf = false, bool includeInactive = true)
         {
             BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);
 
@@ -219,7 +219,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsSibling()
         }
 
         public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInHierarchy(
-            bool includeInactive = false)
+            bool includeInactive = true)
         {
             BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);
 
@@ -236,7 +236,7 @@ public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentInHierarchy(
         }
 
         public ScopeConcreteIdArgConditionCopyNonLazyBinder FromComponentsInHierarchy(
-            Func<TContract, bool> predicate = null, bool includeInactive = false)
+            Func<TContract, bool> predicate = null, bool includeInactive = true)
         {
             BindingUtil.AssertIsInterfaceOrComponent(AllParentTypes);