Fix Exception in AnimationController if disposed whilst actively animating#48
Open
dankhan-helmet wants to merge 12 commits intosrtraj:masterfrom
Open
Fix Exception in AnimationController if disposed whilst actively animating#48dankhan-helmet wants to merge 12 commits intosrtraj:masterfrom
dankhan-helmet wants to merge 12 commits intosrtraj:masterfrom
Conversation
dankhan-helmet
commented
Feb 8, 2024
dankhan-helmet
commented
- When disposing of the dropdown, base code explicitly doesn't dispose of the underlying AnimationController
- If the AnimationController is currently animating when disposed, a ticker will still be active which raises an exception
- Fix to stop any current animations and dispose of the AnimationController when the dropdown is disposed
- When disposing of the dropdown, base code explicitly doesn't dispose of the underlying AnimationController - If the AnimationController is currently animating when disposed, a ticker will still be active which raises an exception - Fix to stop any current animations and dispose of the AnimationController when the dropdown is disposed
- Support theme upgrade in flutter 3.22
Merge straj/dropdown_textfield 1.1.0 updates
Flutter v3.21 had breaking changes https://docs.flutter.dev/release/breaking-changes/material-state
Revert to work with flutter < v3.21
Fix up render bug for overlayKey.currentContext not defined
Update to support flutter v3.22+
Update to support flutter v3.22+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.