Fixed jQuery selector, added single quotes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! I'm assuming this will fix cases where the URL has characters like |
|
Erm, actually, changes will also need to be done in the coffeescript file... I think we should look at removing the dependency, and migrating to ES2016, but that's for later. Can you also edit the coffeescript file? |
srsgores
added a commit
that referenced
this pull request
May 16, 2016
Recompile gruntfile with latest coffeescript Bump version again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added single quotes to jQuery selector.
Broken selector made tabs broken when a hash was given in the url on page load to set current active tab.