Make NodeTask work a bit more like a regular exec call #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add 'executable' syntax sugar for NodeTask
|
Thanks. Any reason that the NodeTask should depend on NpmInstallTask when setting the executable? |
|
The NpmInstallTask dependency is for executables installed via |
This allows calling ExecSpec methods directly from the execOverrides
closure, just like when using exec { } from Gradle normally.
|
+1 Is it possible to expose nodeBinDirPath? I want to copy the downloaded node version to different directory. Without the path it would be hard to figure out the full directory name. Thanks. |
|
This pull request is out of date. Need to fix the conflicts. |
|
Hi, all! Is there any updates for this ticket? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_modules/.bindirectory to NodeTask PATH - this ensures that node scripts can call other node scripts properly. With plain grunt / gulp this is rarely an issue, but it's a problem when other tools like cordova and ionic expect to be able to call grunt/gulp themselves.executablefield to NodeTask for specifying node scripts directly rather than having to manually depend on the npm install and then constructing the file object fromnode_modules/.bin/SCRIPT, and makes it look more like a normal Exec task.