Implement credentials support for distBaseUrl #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Will check it out. Think we could create a "dummy"-server for the integration tests so it's possible to test it. |
|
Any updates on this? |
|
What is the status on this issue? |
|
We've been using this PR in production for about a year now with no issues, is there any chance it could be merged into master? I don't think it'll be possible to ever have tests for this one though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126.
I am new to Gradle/Groovy - please let me know if I've made any rookie mistakes. I would've liked to add an integration test for this, but I don't know of a public https://nodejs.org/dist mirror that requires authentication.
This change is