🛡️ Sentinel: [ENHANCEMENT] Prevent DoS via long version strings #795
Conversation
- Add MAX_VERSION_LENGTH (256) constraint - Replace regex validation with faster charCodeAt loop - Add security test for long strings
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🦋 Changeset detectedLatest commit: 8f612bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 46 52 +6
Branches 16 18 +2
=========================================
+ Hits 46 52 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR introduces a security enhancement to prevent Denial of Service (DoS) attacks via excessively long version strings.
It limits the input length to 256 characters and replaces regex validation with a more performant manual character check.
It also includes a regression test in
src/security.test.ts.PR created automatically by Jules for task 7903150395091579022 started by @srod
Summary by cubic
Prevent DoS/ReDoS from overly long version strings by capping inputs at 256 characters and replacing regex validation with a fast digit-only character check. Adds a regression test for long inputs to ensure invalid versions return false.
Written for commit 8f612bb. Summary will update on new commits.