Fix sponsor level image expanding behind the level description #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any ideas why this works? Or I guess more specifically: why having the height there was causing the overlap? |
Member
|
Having read https://stackoverflow.com/questions/25305550/flexbox-one-element-fixed-height-other-filling and playing a bit I think the issue is potentially that while the flexbox div is limited to this height, the image wasn't and thus grew to its full height. The top of the image was not being hidden (not sure why) but the bottom overflow was. An alternative fix therefore seems to be to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (Mobile)
After (Mobile)
Before (Desktop)
After (Desktop)
Fixes #445