Split trophies and edible prizes into separate tasks #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
reviewed
May 24, 2025
Comment on lines
+16
to
+17
| We usually have around two awards that have edible prizes. | ||
| Typically we give a box of celebrations and a box of jelly babies as the edible prize. |
There was a problem hiding this comment.
Suggestion: maybe note something about the motivations here, rather than just what we tend to do? Including the motivation enables the person doing the task to be better informed in case we want to change things.
Suggested change
| We usually have around two awards that have edible prizes. | |
| Typically we give a box of celebrations and a box of jelly babies as the edible prize. | |
| We usually have around two awards that have edible prizes. | |
| We should ensure that these account for a variety of tastes and dietary requirements. | |
| Typically we give a box of celebrations and a box of jelly babies as the edible prize. |
Add script review process to opening ceremony and prize-giving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally based off of the script-review branch? I couldn't work out how to fix it, but I'm more than happy for someone else to fix it for me. Or we can just merge it as script-review has been merged now?