Skip to content

Borland Updates March 21, 2022 (#265)#290

Merged
lawfordp2017 merged 1 commit intounittests_proposalfrom
master
Apr 29, 2022
Merged

Borland Updates March 21, 2022 (#265)#290
lawfordp2017 merged 1 commit intounittests_proposalfrom
master

Conversation

@lawfordp2017
Copy link
Collaborator

  • Add files via upload

  • Added new parameter to ClassVolumetric fallstat_correction factor which when set multiplies fallstat after its calclulation. It defaults to 1.

  • Correction to ClassCRHMCanopy:

Removing Gamma Distribution Correction term (1.0 + 3.0/Alpha + 2.0/sqr(Alpha))

Term in mean particle mass equation, correction as,
Mpm = 4.0/3.0 * M_PI * PBSM_constants::DICE * RadiusRadiusRadius;

  • Correction to ClassCRHMCanopyClearing:

    Removing Gamma Distribution Correction term (1.0 + 3.0/Alpha + 2.0/sqr(Alpha))

    Term in mean particle mass equation, correction as,
    Mpm = 4.0/3.0 * M_PI * PBSM_constants::DICE * RadiusRadiusRadius;

  • Correction to ClassCRHMCanopyClearingGap:

    Removing Gamma Distribution Correction term (1.0 + 3.0/Alpha + 2.0/sqr(Alpha))

    Term in mean particle mass equation, correction as,
    Mpm = 4.0/3.0 * M_PI * PBSM_constants::DICE * RadiusRadiusRadius;

  • Correction in Classevap

In evap module, /86400 to ra term for rs/ra in Penman-Monteith method, because rs is in d/m while ra is in s/m, correction as,

   evap[hh] = (delta(hru_t[hh])*Q*Global::Freq + (RHOa*Cp/
              (lambda(hru_t[hh])*1e3)*(estar(hru_t[hh]) - hru_ea[hh])/(ra/86400)))/
              (delta(hru_t[hh]) + gamma(Pa[hh], hru_t[hh])*(1.0 + rs[hh]/(ra/86400)))/
              Global::Freq;
  • Updated version dates for modules.

  • Parameter description updates for Classcrack

  • Parameter description updates for ClassGreencrack

  • Parameter description updates for ClassNeedle

  • Parameter description updates for Classnetall

  • Parameter description updates for ClassAyers

  • Parameter description updates for ClassCRHMCanopy

  • Parameter description updates for Classfrozen

  • Parameter description updates for ClassGreenAmpt

  • Parameter description updates for ClassLongVt

  • Parameter description updates for ClassNetroute

  • Parameter description updates for ClassNetroute_D

  • Parameter description updates for ClassNetroute_M

  • Parameter description updates for ClassNetroute_M_D

  • Parameter description updates for ClassPrairieInfill

  • Parameter description updates for ClassREWroute2

  • Parameter description updates for ClassVolumetric

  • Parameter description updates for ClassfrozenAyers

  • Parameter description updates for ClassSoil

  • Parameter description updates for ClassXG

  • Parameter description updates for Classtsurface

  • Parameter description updates for ClassSWEslope

  • Parameter description updates for ClassSoilX

  • Parameter description updates for ClassSoilDS

  • Parameter description updates for ClassShutWallD

  • Parameter description updates for ClassShutWall

  • Parameter description updates for ClassREWroute

  • Parameter description updates for Classlake

  • Parameter description updates for ClassK_Estimate

  • Parameter description updates for Classglacier

  • Parameter description updates for Classevap_Resist

  • Parameter description updates for ClassevapX

  • Parameter description updates for ClassevapD_Resist

  • Parameter description updates for ClassCRHMCanopyClearingGap

  • Parameter description updates for ClassCRHMCanopyClearing

  • Parameter description updates for ClassSoilPrairie

  • Update ClassREWroute2.cpp

  • Update Classtsurface.cpp

  • Update ClassREWroute.cpp

  • Update ClassNetroute_M.cpp

  • Update ClassNetroute_M.cpp

  • Units update for net_snow variable in Classinterception

Co-authored-by: loganxingfang xing.fang@usask.ca
Co-authored-by: jhs507 jhs507@mail.usask.ca

* Add files via upload

* Added new parameter to ClassVolumetric fallstat_correction factor which when set multiplies fallstat after its calclulation. It defaults to 1.

* Correction to ClassCRHMCanopy:

Removing Gamma Distribution Correction term (1.0 + 3.0/Alpha + 2.0/sqr(Alpha))

Term in mean particle mass equation, correction as,
    Mpm = 4.0/3.0 * M_PI * PBSM_constants::DICE * Radius*Radius*Radius;

* Correction to ClassCRHMCanopyClearing:

    Removing Gamma Distribution Correction term (1.0 + 3.0/Alpha + 2.0/sqr(Alpha))

    Term in mean particle mass equation, correction as,
        Mpm = 4.0/3.0 * M_PI * PBSM_constants::DICE * Radius*Radius*Radius;

* Correction to ClassCRHMCanopyClearingGap:

    Removing Gamma Distribution Correction term (1.0 + 3.0/Alpha + 2.0/sqr(Alpha))

    Term in mean particle mass equation, correction as,
        Mpm = 4.0/3.0 * M_PI * PBSM_constants::DICE * Radius*Radius*Radius;

* Correction in Classevap

 In evap module, /86400 to ra term for rs/ra in Penman-Monteith method, because rs is in d/m while ra is in s/m, correction as,

       evap[hh] = (delta(hru_t[hh])*Q*Global::Freq + (RHOa*Cp/
                  (lambda(hru_t[hh])*1e3)*(estar(hru_t[hh]) - hru_ea[hh])/(ra/86400)))/
                  (delta(hru_t[hh]) + gamma(Pa[hh], hru_t[hh])*(1.0 + rs[hh]/(ra/86400)))/
                  Global::Freq;

* Updated version dates for modules.

* Parameter description updates for Classcrack

* Parameter description updates for ClassGreencrack

* Parameter description updates for ClassNeedle

* Parameter description updates for Classnetall

* Parameter description updates for ClassAyers

* Parameter description updates for ClassCRHMCanopy

* Parameter description updates for Classfrozen

* Parameter description updates for ClassGreenAmpt

* Parameter description updates for ClassLongVt

* Parameter description updates for ClassNetroute

* Parameter description updates for ClassNetroute_D

* Parameter description updates for ClassNetroute_M

* Parameter description updates for ClassNetroute_M_D

* Parameter description updates for ClassPrairieInfill

* Parameter description updates for ClassREWroute2

* Parameter description updates for ClassVolumetric

* Parameter description updates for ClassfrozenAyers

* Parameter description updates for ClassSoil

* Parameter description updates for ClassXG

* Parameter description updates for Classtsurface

* Parameter description updates for ClassSWEslope

* Parameter description updates for ClassSoilX

* Parameter description updates for ClassSoilDS

* Parameter description updates for ClassShutWallD

* Parameter description updates for ClassShutWall

* Parameter description updates for ClassREWroute

* Parameter description updates for Classlake

* Parameter description updates for ClassK_Estimate

* Parameter description updates for Classglacier

* Parameter description updates for Classevap_Resist

* Parameter description updates for ClassevapX

* Parameter description updates for ClassevapD_Resist

* Parameter description updates for ClassCRHMCanopyClearingGap

* Parameter description updates for ClassCRHMCanopyClearing

* Parameter description updates for ClassSoilPrairie

* Update ClassREWroute2.cpp

* Update Classtsurface.cpp

* Update ClassREWroute.cpp

* Update ClassNetroute_M.cpp

* Update ClassNetroute_M.cpp

* Units update for net_snow variable in Classinterception

Co-authored-by: loganxingfang <xing.fang@usask.ca>
Co-authored-by: jhs507 <jhs507@mail.usask.ca>
@lawfordp2017 lawfordp2017 merged commit 781757e into unittests_proposal Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants