Implement clab save for IOL.
#2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was redundant regex for the `eX/X` and `EthernetX/X` checks. The regexp has been simplified so "e" vs "Ethernet" and the slot/port checks are in two separate capture groups.
`SaveConfig()` func is used which allows the "clab save" command to be used. Uses the scrapligo network driver to send a basic `write memory` command which copies the running config -> startup config.
hellt
reviewed
Jan 17, 2025
Comment on lines
+384
to
+385
| // SaveConfig is used for "clab save" functionality -- it saves the running config to the startup configuration | ||
| func (n *iol) SaveConfig(_ context.Context) error { |
There was a problem hiding this comment.
@kaelemc can you add a simple robot test in the iol test suite?
Just call a command and check if it returns rc=0 at a mininum.
If you want to make it more proper, maybe you can check with some show command that the stratup has actually been written to
Some basic tests which use "containerlab save" to save all running configurations to the startup-configuration (in NVRAM). The test then verifies the config was saved to the startup-config by checking the startup-config location contains a configuration with the nodes hostname.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
==========================================
+ Coverage 51.97% 52.56% +0.59%
==========================================
Files 172 168 -4
Lines 17394 16940 -454
==========================================
- Hits 9040 8905 -135
+ Misses 7412 7122 -290
+ Partials 942 913 -29
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title this PR:
clab savefor IOLAllowedIntfRegexpI've pretty much stolen the sample in the scrapligo README and modified it to exec
write memorywhich does the same ascopy run start, the difference being withwrite memorythere is no pesky prompt that shows up to confirm you want to copy the config.I'll add some tests, but let me know if you like it this way or would prefer something else.
FYI: "programmability" is not supported on IOL (this includes NETCONF).