Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for EL distros in one-liner install script. #2137

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

kaelemc
Copy link
Contributor

@kaelemc kaelemc commented Jul 10, 2024

This PR enables the one liner install script to support RHEL & other EL counterparts like Fedora, Rocky and CentOS to name a few.

Currently tested on Rocky 9.3. This is in draft PR status while I test other distros & versions.

@kaelemc kaelemc changed the title Add suport for EL distros. Add suport for EL distros in one-liner install script. Jul 10, 2024
@kaelemc
Copy link
Contributor Author

kaelemc commented Jul 10, 2024

Confirmed working on RHEL 9 (Developer edition) and CentOS 9.

utils/quick-setup.sh Outdated Show resolved Hide resolved
@kaelemc
Copy link
Contributor Author

kaelemc commented Jul 10, 2024

Confirmed basic containerlab functionality by running srl-quickstart on:

  • Rocky 9.3
  • Rocky 8.8
  • Fedora Server 40
  • RHEL 9 w/Developer Subscription
  • CentOS Stream 9
  • Ubuntu 22.04 Server

@kaelemc kaelemc marked this pull request as ready for review July 10, 2024 11:07
@hellt
Copy link
Member

hellt commented Jul 10, 2024

Thanks @kaelemc

Would you mind adding the tested systems here as well?

https://containerlab.dev/install/#quick-setup

I also see that dnf is used to install packages, I guess this rules out ancient systems like centos7 that don't have dnf client? Or maybe it does?

@kaelemc
Copy link
Contributor Author

kaelemc commented Jul 10, 2024

Oh yes, I will add the relevant documentation. Thanks for the reminder.

Yes dnf is used to install github cli and for the Fedora docker installation.

RHEL 7 is going EOL this year, and I personally think it's unlikely people would be installing clab on a RHEL 7 based distro so we are probably fine on that front.

@kaelemc
Copy link
Contributor Author

kaelemc commented Jul 10, 2024

Scrap that, RHEL7/CentOS already is EOL as of June 2024.

@kaelemc
Copy link
Contributor Author

kaelemc commented Jul 10, 2024

Just want your guidance on two things:

  1. Should the script perform (or the documentation specify) that users can/should perform the docker postinstall. It makes things easier and cleaner for the user (assuming the machine only runs containerlab because of the security implications etc.), . Effectively means newer users might find it easier to use containerlab out-of-the-box.

  2. Should the script install make which is required for vrnetlab? Or should we leave that up to the user to do?

@hellt
Copy link
Member

hellt commented Jul 10, 2024

@kaelemc
yes, I always wanted to add the docker user group to this script. I see that it is part of the postinstall, so we should definitely do this while we are at it.

and yes, make we should install as well

@kaelemc
Copy link
Contributor Author

kaelemc commented Jul 10, 2024

@hellt Added those two things. Confirmed working on Ubuntu & Rocky.

@hellt hellt merged commit 5ef40fe into srl-labs:main Jul 10, 2024
1 check passed
@hellt
Copy link
Member

hellt commented Jul 10, 2024

Thanks again @kaelemc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants