fix: Npm ignores files and folders named "core" by default (aws#1767)

Since the release of `npm@6.8.0`, a version of `npm-packlist` is included that introduces a behavior to ignore anything named "core" by default. Added `!core` to the `.npmignore` file as a work around, and also more strictly pinned the `npm` version to auto-upgrade to so we don't get surprised in this kind of way anymore. Cause: npm/npm-packlist#24
srknc · Feb 14, 2019 · 42876e7 · 42876e7
1 parent 73d5bef
commit 42876e7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/install.sh b/install.sh
@@ -5,7 +5,7 @@ export NODE_OPTIONS="--max-old-space-size=4096 ${NODE_OPTIONS:-}"
 
 if ! npm ci --help; then
   echo "upgrading npm, because "npm ci" is not supported"
-  npm i -g npm
+  npm i -g npm@~6.8.0
 fi
 
 echo "============================================================================================="

diff --git a/packages/@aws-cdk/cdk/.npmignore b/packages/@aws-cdk/cdk/.npmignore
@@ -13,4 +13,7 @@ dist
 # Include .jsii
 !.jsii
 
-*.snk
+*.snk
+
+# Work around npm@6.8.0 ignoring 'core' by default -- https://github.com/npm/npm-packlist/issues/24
+!core
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,4 +13,7 @@ dist @@
     # Include .jsii
     !.jsii
-    *.snk
+    *.snk
+    # Work around npm@6.8.0 ignoring 'core' by default -- https://github.com/npm/npm-packlist/issues/24
+    !core