Fix comments for pull request ros2#93

Signed-off-by: Sriram Raghunathan <rsriram7@visteon.com>
sriramster · May 15, 2019 · b6f4dfa · b6f4dfa
1 parent 40260c4
commit b6f4dfa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/rosbag2/include/rosbag2/writer.hpp b/rosbag2/include/rosbag2/writer.hpp
@@ -84,7 +84,6 @@ class ROSBAG2_PUBLIC Writer
    * \param topic_with_type name and type identifier of topic to be created
    * \throws runtime_error if the Writer is not open.
    */
-
   virtual void remove_topic(const TopicMetadata & topic_with_type);
 
   /**

diff --git a/rosbag2_transport/src/rosbag2_transport/recorder.cpp b/rosbag2_transport/src/rosbag2_transport/recorder.cpp
@@ -106,22 +106,18 @@ void Recorder::subscribe_topics(
 
 void Recorder::subscribe_topic(const rosbag2::TopicMetadata & topic)
 {
-  if(writer_) {
-    writer_->create_topic(topic);
-    subscribed_topics_.insert(topic.name);
-  }
-
   auto subscription = create_subscription(topic.name, topic.type);
 
   if (subscription) {
+    writer_->create_topic(topic);
+    subscribed_topics_.insert(topic.name);
     subscriptions_.push_back(subscription);
     ROSBAG2_TRANSPORT_LOG_INFO_STREAM("Subscribed to topic '" << topic.name << "'");
   }
   else {
     writer_->remove_topic(topic);
     subscribed_topics_.erase(topic.name);
   }
-
 }
 
 std::shared_ptr<GenericSubscription>
-Original file line number
+Diff line change
@@ Expand Up / @@ -84,7 +84,6 @@ class ROSBAG2_PUBLIC Writer @@
        * \param topic_with_type name and type identifier of topic to be created
        * \throws runtime_error if the Writer is not open.
        */
       virtual void remove_topic(const TopicMetadata & topic_with_type);
       /**
@@ Expand Down @@