Skip to content

[fix] OBJ_ENCODING_INT sds string is between LONG_MIN and LONG_MAX #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] OBJ_ENCODING_INT sds string is between LONG_MIN and LONG_MAX #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rdbtools/memprofiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,13 @@ def sizeof_string(self, string):
# https://github.com/antirez/redis/blob/unstable/src/sds.h
try:
num = int(string)
if num < REDIS_SHARED_INTEGERS :
tmp_str = str(num)
long_max = (1 << (self._architecture - 1)) - 1

# if string like '0****' or '-0***', should calculate malloc_overhead
# if num is between long_min and long_max,the integer is part of the robj, no extra memory
if string == tmp_str and -long_max - 1 <= num <= long_max:
return 0
else :
return 0 # the integer is part of the robj, no extra memory
except ValueError:
pass
l = len(string)
Expand Down