refactor: consume kolu's W4 SurfaceAppProvider accessor (juspay/kolu#1708) - #89
Closed
srid wants to merge 8 commits into
Closed
refactor: consume kolu's W4 SurfaceAppProvider accessor (juspay/kolu#1708)#89srid wants to merge 8 commits into
srid wants to merge 8 commits into
Conversation
…1708) kolu's W4 "the switch" makes `SurfaceAppProvider.controlPlane` an `Accessor<ControlPlane<T>>` so a live host switch tears down the old build-identity stream and re-subscribes (the framework guarantee). drishti is the paired second consumer (`.claude/rules/surface.md`): its `surfaceAppClient` is already accessor-shaped, so the adoption is dropping the `()` — pass the accessor itself. drishti's admin control plane is stable, so its provider simply never trips the swap. Re-pins npins to the kolu W4 branch HEAD (d7ba2e9a62); re-pin to master after the kolu PR squash-merges, per the same-SHA gate.
…icker submit fix)
Owner
Author
|
Closing with juspay/kolu#1708 (its pairing partner) — superseded by the surface-family redesign; drishti's paired PR for the successor will be a substantive adoption (hostRegistry/admin-surface consuming @kolu/surface-family), not a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paired consumer PR for kolu's W4 "the switch" (juspay/kolu#1708) — the
.claude/rules/surface.mdgate.What changed in kolu
SurfaceAppProvider.controlPlanebecomesAccessor<ControlPlane<T>>(the ratified S5 shape): a live host switch yields a new client, and the provider tears down the old build-identity stream and re-subscribes — a framework guarantee, so a consumer can't leak the old host's stream.Consumer impact
One line:
controlPlane={surfaceAppClient()}→controlPlane={surfaceAppClient}. drishti'ssurfaceAppClientis already accessor-shaped (a lazy admin-client getter), so the adoption is passing the accessor itself instead of its invoked value. drishti's admin control plane is stable across the fleet, so its provider simply never trips the swap — but it compiles + runs green against the new prop type, which is the gate.Re-pins
npinsto the kolu W4 branch HEAD (d7ba2e9a62). Per the same-SHA gate, this will be re-pinned to kolu master after the kolu PR squash-merges, and re-confirmed green there.🤖 Generated with Claude Code