-
-
Notifications
You must be signed in to change notification settings - Fork 216
Fixed Android version detection function and audio bridge chooser #261
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/srevinsaju/guiscrcpy/Cun1jP6yuBz9x3QnYRq95aDvJajH |
Hey! I have made the changes you asked for :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Thank you! But why are the checks failing? I forked the repo's main branch and older commits were passing checks.. I hadn't changed anything other than these two files. And will this be merged? |
lol, don't hurry lol, I am also having a bunch of classes, and didnt get time to review this properly. I will test this locally on my machine and merge this haha. |
Oh 😅 |
By the way, you should not commit to main branch generally, but its okay for this PR, you should create a new branch and add commits there, and create a PR from there, this will make sure that your main branch is clean. |
true, will keep that in mind from now on :) |
Nice, tested with Android 10, sndcpy was detected and was launched. Great work! |
Thank you!! |
Hey, @srevinsaju I can write the docs for building guiscrcpy on m1 macs, can you please open the issue for that and also tell some guidelines I would need to follow. |
@gouravkhunger Thank you! I added an issue #264, feel free to take up the task and work on it. By the way, are you interested in being a guiscrcpy project maintainer for macOS, i.e becoming a official homebrew packager for guiscrcpy, also i.e releasing guiscrcpy as an official package on homebrew so that other macOS users can install them like |
Woah, that would be amazing @srevinsaju !! Thanks for this opportunity. And yeah I will write the docs within a few days! |
I changed the
get_target_android_version()
function to rely on the device's API level instead of getting the version string and extracting the number from there, which is bug-prone.API levels are integer numbers for the SDK a specific set of Android versions uses. Here's the list of all the API levels.
Noting that Any device with Android version 10 and above, will have API level greater than 28, I fixed the
launch_usb_audio()
function to usescndcpy
orusbaudio
depending on the case.This should fix #243 and #248
Reference: #260