-
Notifications
You must be signed in to change notification settings - Fork 414
Description
The README of this project: https://github.com/jfloff/pywFM states:
Make sure you are compiling source from libfm repository and at this specific commit, since pywFM needs the save_model. Beware that the installers and source code in libfm.org are both dated before this commit. I know this is extremely hacky, but since a fix was deployed it only allows the save_model option for SGD or ALS. I don't know why exactly, because it was working well before.
It seems weird to me that the author hasn't approached you to find a better solution than this hack, and I'm not familiar enough with the code to suggest a PR that would solve the problem cleanly. Besides, currently there's no explicit explanation as to why you forbid to load/save for things other than SGD or ALS, so I don't know where I could do that.
Therefore, I'm making this issue to see if we could find a better solution than this! :-)
@srendle Could you explain what the problem with other models are, and why this check is in place?
@jfloff Could you tell us why pywFM needs to be able to save/load different kinds of models than SGD and ALS?
Thanks!