chore: update to go1.19.1 (influxdata#11776)

.circleci/config.yml

@@ -8,7 +8,7 @@ executors:
     working_directory: '/go/src/github.com/influxdata/telegraf'
     resource_class: large
     docker:
-      - image: 'quay.io/influxdb/telegraf-ci:1.18.5'
+      - image: 'quay.io/influxdb/telegraf-ci:1.19.1'
     environment:
       GOFLAGS: -p=4
   mac:

Makefile

@@ -242,8 +242,8 @@ plugins/parsers/influx/machine.go: plugins/parsers/influx/machine.go.rl
 
 .PHONY: ci
 ci:
-	docker build -t quay.io/influxdb/telegraf-ci:1.18.5 - < scripts/ci.docker
-	docker push quay.io/influxdb/telegraf-ci:1.18.5
+	docker build -t quay.io/influxdb/telegraf-ci:1.19.1 - < scripts/ci.docker
+	docker push quay.io/influxdb/telegraf-ci:1.19.1
 
 .PHONY: install
 install: $(buildbin)

agent/agent.go

@@ -50,6 +50,7 @@ type inputUnit struct {
 //  ______     ┌───────────┐     ______
 // ()_____)──▶ │ Processor │──▶ ()_____)
 //             └───────────┘
+
 type processorUnit struct {
 	src       <-chan telegraf.Metric
 	dst       chan<- telegraf.Metric
@@ -59,7 +60,7 @@ type processorUnit struct {
 // aggregatorUnit is a group of Aggregators and their source and sink channels.
 // Typically the aggregators write to a processor channel and pass the original
 // metrics to the output channel.  The sink channels may be the same channel.
-//
+
 //                 ┌────────────┐
 //            ┌──▶ │ Aggregator │───┐
 //            │    └────────────┘   │
@@ -71,6 +72,7 @@ type processorUnit struct {
 //            │    └────────────┘
 //            │                           ______
 //            └────────────────────────▶ ()_____)
+
 type aggregatorUnit struct {
 	src         <-chan telegraf.Metric
 	aggC        chan<- telegraf.Metric
@@ -80,7 +82,7 @@ type aggregatorUnit struct {
 
 // outputUnit is a group of Outputs and their source channel.  Metrics on the
 // channel are written to all outputs.
-//
+
 //                            ┌────────┐
 //                       ┌──▶ │ Output │
 //                       │    └────────┘
@@ -90,6 +92,7 @@ type aggregatorUnit struct {
 //                       │    ┌────────┐
 //                       └──▶ │ Output │
 //                            └────────┘
+
 type outputUnit struct {
 	src     <-chan telegraf.Metric
 	outputs []*models.RunningOutput

cmd/telegraf/printer.go

@@ -54,6 +54,7 @@ var globalTagsConfig = `
 `
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the agentConfig data.
+//
 //go:embed agent.conf
 var agentConfig string
 

filter/filter.go

@@ -14,11 +14,10 @@ type Filter interface {
 // for matching a given string against the filter list. The filter list
 // supports glob matching too, ie:
 //
-//   f, _ := Compile([]string{"cpu", "mem", "net*"})
-//   f.Match("cpu")     // true
-//   f.Match("network") // true
-//   f.Match("memory")  // false
-//
+//	f, _ := Compile([]string{"cpu", "mem", "net*"})
+//	f.Match("cpu")     // true
+//	f.Match("network") // true
+//	f.Match("memory")  // false
 func Compile(filters []string) (Filter, error) {
 	// return if there is nothing to compile
 	if len(filters) == 0 {

go.mod

@@ -1,6 +1,6 @@
 module github.com/influxdata/telegraf
 
-go 1.18
+go 1.19
 
 // Workaround for https://github.com/lxc/lxd/issues/10745 (failing "go list -m all")
 replace google.golang.org/grpc/naming => google.golang.org/grpc v1.29.1

internal/snmp/translate.go

@@ -49,7 +49,7 @@ func ClearCache() {
 	cache = make(map[string]bool)
 }
 
-//will give all found folders to gosmi and load in all modules found in the folders
+// will give all found folders to gosmi and load in all modules found in the folders
 func LoadMibsFromPath(paths []string, log telegraf.Logger, loader MibLoader) error {
 	folders, err := walkPaths(paths, log)
 	if err != nil {
@@ -89,7 +89,7 @@ func LoadMibsFromPath(paths []string, log telegraf.Logger, loader MibLoader) err
 	return nil
 }
 
-//should walk the paths given and find all folders
+// should walk the paths given and find all folders
 func walkPaths(paths []string, log telegraf.Logger) ([]string, error) {
 	once.Do(gosmi.Init)
 	folders := []string{}

internal/templating/node.go

@@ -105,16 +105,18 @@ type nodes []*node
 // less than a non-wildcard value.
 //
 // For example, the filters:
-//             "*.*"
-//             "servers.*"
-//             "servers.localhost"
-//             "*.localhost"
+//
+//	"*.*"
+//	"servers.*"
+//	"servers.localhost"
+//	"*.localhost"
 //
 // Would be sorted as:
-//             "servers.localhost"
-//             "servers.*"
-//             "*.localhost"
-//             "*.*"
+//
+//	"servers.localhost"
+//	"servers.*"
+//	"*.localhost"
+//	"*.*"
 func (n *nodes) Less(j, k int) bool {
 	if (*n)[j].value == "*" && (*n)[k].value != "*" {
 		return false

plugins/aggregators/basicstats/basicstats.go

@@ -11,6 +11,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/derivative/derivative.go

@@ -11,6 +11,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/final/final.go

@@ -11,6 +11,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/histogram/histogram.go

@@ -13,6 +13,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/merge/merge.go

@@ -11,6 +11,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/minmax/minmax.go

@@ -9,6 +9,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/quantile/quantile.go

@@ -10,6 +10,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/starlark/starlark.go

@@ -12,6 +12,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/aggregators/valuecounter/valuecounter.go

@@ -10,6 +10,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/common/shim/example/cmd/main.go

@@ -22,16 +22,16 @@ var err error
 // However, if you want to do all your config in code, you can like so:
 //
 // // initialize your plugin with any settings you want
-// myInput := &mypluginname.MyPlugin{
-// 	DefaultSettingHere: 3,
-// }
+//
+//	myInput := &mypluginname.MyPlugin{
+//		DefaultSettingHere: 3,
+//	}
 //
 // shim := shim.New()
 //
 // shim.AddInput(myInput)
 //
 // // now the shim.Run() call as below. Note the shim is only intended to run a single plugin.
-//
 func main() {
 	// parse command line options
 	flag.Parse()

plugins/inputs/activemq/activemq.go

@@ -20,6 +20,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/aerospike/aerospike.go

@@ -19,6 +19,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/aliyuncms/aliyuncms.go

@@ -24,6 +24,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 
@@ -341,7 +342,7 @@ func (s *AliyunCMS) gatherMetric(acc telegraf.Accumulator, metricName string, me
 	return nil
 }
 
-//tag helper
+// tag helper
 func parseTag(tagSpec string, data interface{}) (tagKey string, tagValue string, err error) {
 	var (
 		ok        bool

plugins/inputs/aliyuncms/discovery.go

@@ -52,8 +52,8 @@ type parsedDResp struct {
 	pageNumber int
 }
 
-//getRPCReqFromDiscoveryRequest - utility function to map between aliyun request primitives
-//discoveryRequest represents different type of discovery requests
+// getRPCReqFromDiscoveryRequest - utility function to map between aliyun request primitives
+// discoveryRequest represents different type of discovery requests
 func getRPCReqFromDiscoveryRequest(req discoveryRequest) (*requests.RpcRequest, error) {
 	if reflect.ValueOf(req).Type().Kind() != reflect.Ptr ||
 		reflect.ValueOf(req).IsNil() {
@@ -80,12 +80,12 @@ func getRPCReqFromDiscoveryRequest(req discoveryRequest) (*requests.RpcRequest,
 	return nil, errors.Errorf("didn't find *requests.RpcRequest embedded struct in %q", ptrV.Type())
 }
 
-//newDiscoveryTool function returns discovery tool object.
-//The object is used to periodically get data about aliyun objects and send this
-//data into channel. The intention is to enrich reported metrics with discovery data.
-//Discovery is supported for a limited set of object types (defined by project) and can be extended in future.
-//Discovery can be limited by region if not set, then all regions is queried.
-//Request against API can inquire additional costs, consult with aliyun API documentation.
+// newDiscoveryTool function returns discovery tool object.
+// The object is used to periodically get data about aliyun objects and send this
+// data into channel. The intention is to enrich reported metrics with discovery data.
+// Discovery is supported for a limited set of object types (defined by project) and can be extended in future.
+// Discovery can be limited by region if not set, then all regions is queried.
+// Request against API can inquire additional costs, consult with aliyun API documentation.
 func newDiscoveryTool(regions []string, project string, lg telegraf.Logger, credential auth.Credential, rateLimit int, discoveryInterval time.Duration) (*discoveryTool, error) {
 	var (
 		dscReq                = map[string]discoveryRequest{}

plugins/inputs/amd_rocm_smi/amd_rocm_smi.go

@@ -18,6 +18,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/amqp_consumer/amqp_consumer.go

@@ -21,6 +21,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/apache/apache.go

@@ -20,6 +20,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/apcupsd/apcupsd.go

@@ -17,6 +17,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/aurora/aurora.go

@@ -19,6 +19,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/azure_storage_queue/azure_storage_queue.go

@@ -16,6 +16,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/bcache/bcache.go

@@ -20,6 +20,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/beanstalkd/beanstalkd.go

@@ -15,6 +15,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/beat/beat.go

@@ -18,6 +18,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/bind/bind.go

@@ -15,6 +15,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/bond/bond.go

@@ -15,6 +15,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/burrow/burrow.go

@@ -21,6 +21,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string
 

plugins/inputs/cassandra/cassandra.go

@@ -16,6 +16,7 @@ import (
 )
 
 // DO NOT REMOVE THE NEXT TWO LINES! This is required to embed the sampleConfig data.
+//
 //go:embed sample.conf
 var sampleConfig string