Skip to content

Record errors branch #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Record errors branch #80

wants to merge 2 commits into from

Conversation

@kyrcha
Copy link
Contributor

@kyrcha kyrcha commented Oct 25, 2019

Signed-off-by: Kyriakos Chatzidimitriou kyrcha@gmail.com

This PR addresses #13 issue. Adds:

  • tests retry for big queries producing 502
  • test errors that come with 200 OK status
  • refactors recordings
  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

kyrcha added 2 commits October 24, 2019 18:46
@kyrcha
Test retry, test some 200 errors, refactor recordings code
c82a1c6 
Signed-off-by: Kyriakos Chatzidimitriou <kyrcha@gmail.com>
@kyrcha
Skip onilne retry tests on travis if token is unset
373485d 
Signed-off-by: Kyriakos Chatzidimitriou <kyrcha@gmail.com>
@kyrcha kyrcha self-assigned this Oct 25, 2019
@kyrcha kyrcha mentioned this pull request Oct 25, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smacker smacker Awaiting requested review from smacker

@se7entyse7en se7entyse7en Awaiting requested review from se7entyse7en

Assignees

@kyrcha kyrcha

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kyrcha