GetChanges does not return deleted files

[carlosms]

Right now GetChanges does not return deleted files.
This issue is to decide if we want to change this or keep it.

It makes sense to filter out deleted files since analyzers are supposed to add comments to new changes, and maybe this edge case is not considered by the current analyzers.
On the other hand we don't remove deleted and context lines from diffs, so maybe a deleted file should also not dissapear from the response. And there might be a use case for an analyzer that is interested in knowing if any file was deleted in a PR.

Currently, the filtering is happening in the regexp scanner, here. If we want to keep this behaviour I think we should make it more explicit and filter in a more obvious place.

[smacker]

It's definitely a bug.

Actually, we return deleted files if regexp filters are empty:

lookout/service/git/service.go

Line 77 in d29e69d

if req.IncludePattern != "" || req.ExcludePattern != "" {

I made one line fix for filter scanner.