Skip to content

[improvement] better logging #368

@EgorBu

Description

@EgorBu

Hi,
It would be nice to improve the logging message so it's easy to understand what was the reason of failure.
Example:

[2018-11-28T12:41:12.035318241+01:00]  INFO streaming client call finished app=lookout-sdk duration=30m0.000160806s error=rpc error: code = DeadlineExceeded desc = Deadline Exceeded grpc.code=DeadlineExceeded grpc.method=NotifyPushEvent grpc.service=pb.Analyzer grpc.start_time=2018-11-28T12:11:12+01:00 source=grpchelper/logger.go:19 span.kind=client system=grpc
[2018-11-28T12:41:12.035542004+01:00] ERROR analysis failed analyzer=test-analyzes app=lookout-sdk error=rpc error: code = DeadlineExceeded desc = Deadline Exceeded provider= source=server/server.go:275

it appeared during push event but it's hard to guess that analyzer_push should be modified in configuration until you read https://github.com/src-d/lookout/blob/master/docs/configuration.md#advanced-fine-tuning

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions