This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql: implement index catalog #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
reviewed
Apr 27, 2018
sql/index.go
Outdated
| defer r.mut.RUnlock() | ||
|
|
||
| id = strings.ToLower(id) | ||
| for _, idx := range r.indexes { |
There was a problem hiding this comment.
maybe indexes can be a map["${db}.${id}"]Index (if id is unique per db) so we can speed up a lookup
There was a problem hiding this comment.
We need to iterate anyway for the IndexByExpression, but ok, we can speed up getting by key.
ajnavarro
approved these changes
May 3, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/index-catalog
branch
from
fb2780b to
c2f9e5c
Compare
|
Done @kuba-- |
|
@kuba-- @erizocosmico shall we merge this? |
|
SGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
I removed the
Status() IndexStatusfrom theIndexinterface, since doing that would require aSetStatusand I don't really think we should expose that method.