This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Don't assign err from ForEach loop #1188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't check the value anyway, as it can't possibly be anything but nil. Signed-off-by: Christian Muehlhaeuser <muesli@gmail.com>
|
Thanks for keep go-git clean and tidy. Can you group this batch of PRs in one? Since all are related? |
|
@mcuadros Sure, which ones would you like to see merged? I actually tried to split them up in logical, related pieces already. For example, I don't think simple fixes like this one belong together with changes that actually change behavior, or test-related changes. Up to you though, just let me know. |
|
I suggest to merge all in one, since all are about the same nature. |
|
I did myself, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't check the value anyway, as it can't possibly be anything but nil.