vendor: upgrade go-mysql-server #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
approved these changes
Sep 24, 2018
Contributor
kuba--
left a comment
kuba--
left a comment
There was a problem hiding this comment.
I think it should be automatically approved after tests pass.
Contributor
|
@erizocosmico can you have a quick look, please? |
Contributor
Author
|
Sure @ajnavarro |
Contributor
Author
|
Update had breaking changes and forgot to update them. Should be fine now |
Contributor
Author
|
It's still failing, looking into it |
This was referenced Sep 24, 2018
Contributor
|
@erizocosmico can you update it again please (sorry for all the noise)? |
Contributor
Author
|
done |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Contributor
Author
|
Fixed again, required some changes here this time |
ajnavarro
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #481