List endpoints with repository transaction #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Since the issues, PRs and the reposity are all commited at the same time, we can remove the FindOne checks for issues and because we already know the repository was not found Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Merged
|
If it doesn't improve performance I don't think we should merge it. |
|
One of my concerns is if we remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #30.
Done on top of #32, only the last commit is relevant 5249912.
Since the issues, PRs and the repository are all committed at the same time, we can remove the
FindOnechecks for issues and PRs because we already know the repository was not found.After testing this change the download times for
src-ddid not change, it's still around 15m. That's why I'm submitting this as a separate PR, in case we consider this complicates the code and prefer to just merge #32.