Refactoring: reconciling schema \w Apollo Meta DB#48
Merged
bzz merged 8 commits intosrc-d:masterfrom Mar 9, 2018
Merged
Conversation
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
5 tasks
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
bzz
changed the title
smacker
approved these changes
Mar 6, 2018
Contributor
smacker
left a comment
smacker
left a comment
There was a problem hiding this comment.
looks good!
P.S. Do you use any formatter or linter for scala, beside default formatter in IntelliJ IDEA? I would be nice if all of us use the same configuration for code style.
Contributor
Author
|
Thank you for prompt review @smacker ! Indeed, it's only IDE formatter support for now. Have filed issues for linter/formatter support. |
Contributor
|
thank you so much! |
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Contributor
Author
|
History was re-written but only last 2 commits were actually added, to include same changes in Golang query implementation. |
bzz
force-pushed
the
apollo-schema
branch
2 times, most recently
from
5a78be4 to
6843475
Compare
Signed-off-by: Alexander Bezzubov <bzz@apache.org>
Contributor
Author
|
Merging, if there is no further discussion |
carlosms
approved these changes
Mar 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #47
First step on the way to allow hash \w Apollo and query \w Gemini