Supress md5 logs. #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuba-- <kuba@sourced.tech>
erizocosmico
approved these changes
Oct 18, 2018
jfontan
approved these changes
Oct 18, 2018
mcarmonaa
approved these changes
Oct 18, 2018
rporres
approved these changes
Oct 18, 2018
campoy
approved these changes
Oct 18, 2018
Signed-off-by: kuba-- <kuba@sourced.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech
If the only reason why we try to download MD5 is to check if the file is up to date (nothing else) then lets make
matchHashjust as a boolean function, instead of returning boolean and an error (it's like a fuzzy logic).At least it will suppress the annoying warning.
I know it may look like not a right fix, but so far we don't verify hashes (saying it's middleman hack or whatever). We just say latest or not and in case of false we double check it. So logging missed md5 as a warning is too annoying IMO.