Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pga: add flag to the command to select pga version to download #111

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

mcarmonaa
Copy link
Contributor

@mcarmonaa mcarmonaa commented Mar 11, 2019

Closes #108

Right now there is only one pga version so HTTP calls are hardcoded to be done to (for both either index or siva files):

http://pga.sourced.tech/csv/latest.csv.gz
http://pga.sourced.tech/siva/latest/xx/xx7303c49ac984a9fec60523f2d5297682e16646.siva

Adding the root flag --pga-version it allows you to select which version of the pga you want to work with, requesting for paths like:

http://pga.sourced.tech/csv/v1.csv.gz
http://pga.sourced.tech/siva/v1/xx/xx7303c49ac984a9fec60523f2d5297682e16646.siva

latest is set by default which is the only version working for the moment.

Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
@mcarmonaa mcarmonaa requested a review from a team March 11, 2019 13:36
@jfontan jfontan merged commit 3616675 into src-d:master Mar 11, 2019
@mcarmonaa mcarmonaa deleted the feature/select-version branch March 11, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants