Implement features endpoint #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
|
\cc @carlosms for review |
|
Maybe we should restrict this route only for users with the Requester role. Do you agree? |
|
we don't have ACL yet. But we should later, yes. |
|
The roles are already in models.go, and #60 should be merged soon. I'd make this change to save us a new PR in a few hours. Up to you. Otherwise, looks good. |
carlosms
approved these changes
Feb 9, 2018
|
You won't be able to test it after merge then. I prefer going step by step. In my opinion, the right place to implement it is connection FE to BE. Because the same restriction will be needed on FE side. |
|
I'm ok with any option as long as we don't forget about it. Can you please make a new issue, or add a comment to the relevant issue to make sure we don't forget? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44