Skip to content

Conversation

dpordomingo
Copy link
Contributor

No description provided.

src/logo.svg Outdated
@@ -0,0 +1,7 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 841.9 595.3">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://github.com/facebook/react/blob/master/LICENSE this logo seems to be MIT licensed, which is compatible with GPL3 but we would need to track this somewhere, if we start mixing licenses inside a single codebase.

I would suggest we either remove it, or replace it with something we own, that can be covered by GPL 3 as everything else in this repo.

@bzz
Copy link
Contributor

bzz commented Jan 12, 2018

Looks great to me, sans minor potential licensing issue noted above.

@dpordomingo
Copy link
Contributor Author

Thanks @bzz for reviewing the licenses.
@smacker since everything is yours, but the last commit 4c7b9e9 that's the only one that you'd review :D

@dpordomingo
Copy link
Contributor Author

PS: @bzz should we remove that icon from everywhere in our history? or is it enough with that commit 4c7b9e9 removing it? If so, I can do it.

@bzz
Copy link
Contributor

bzz commented Jan 12, 2018

It's enough not to have it in the version of the source code, that will be distributed.

It's actually preferable to have it in the history with excellent commit message on how it's been taken care of, before it became an issue.

Thank you @dpordomingo for taking care of it - looks great to me.

Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's merge, if there is no further discussion so it could serve as excellent foundation for future work!

@bzz bzz merged commit 5ceb4d3 into src-d:master Jan 12, 2018
@dpordomingo dpordomingo mentioned this pull request Jan 19, 2018
@dpordomingo dpordomingo deleted the initial-work branch January 30, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants