-
Notifications
You must be signed in to change notification settings - Fork 26
Merge initial work into official initial commit #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/logo.svg
Outdated
@@ -0,0 +1,7 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 841.9 595.3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://github.com/facebook/react/blob/master/LICENSE this logo seems to be MIT licensed, which is compatible with GPL3 but we would need to track this somewhere, if we start mixing licenses inside a single codebase.
I would suggest we either remove it, or replace it with something we own, that can be covered by GPL 3 as everything else in this repo.
Looks great to me, sans minor potential licensing issue noted above. |
a16cd3c
to
4c7b9e9
Compare
It's enough not to have it in the version of the source code, that will be distributed. It's actually preferable to have it in the history with excellent commit message on how it's been taken care of, before it became an issue. Thank you @dpordomingo for taking care of it - looks great to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's merge, if there is no further discussion so it could serve as excellent foundation for future work!
No description provided.