Implement handlers #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smacker
reviewed
Jan 30, 2018
server/handler/assignments.go
Outdated
| return nil, fmt.Errorf("wrong format in experiment ID sent; received %s", requestedExperimentID) | ||
| } | ||
|
|
||
| // TODO: fetch from user in session |
There was a problem hiding this comment.
why don't use jwt.GetUserID? Middleware is already there.
smacker
reviewed
Jan 30, 2018
| assignments, err := repository.GetAssignmentsFor(userID, experimentID) | ||
| if err == repository.ErrNoAssignmentsInitialized { | ||
| if assignments, err = repository.CreateAssignmentsFor(userID, experimentID); err != nil { | ||
| return nil, fmt.Errorf("no available assignments") |
There was a problem hiding this comment.
the original error should be logged (ok to do in separate PR)
There was a problem hiding this comment.
I'll do so by #50
smacker
reviewed
Jan 30, 2018
server/handler/assignments.go
Outdated
| requestedAssignmentID := chi.URLParam(r, "assignmentId") | ||
| assignmentID, err := strconv.Atoi(requestedAssignmentID) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("wrong format in assignment ID sent; received %s", requestedAssignmentID) |
There was a problem hiding this comment.
it's not 500 but 404 or 400. Ok to do in separate PR.
|
also CI is failing with error |
|
@smacker your comments were addressed 💃 |
smacker
approved these changes
Jan 30, 2018
From the PR feedback: - Expose right HTTP status codes as spotted by @smacker
dpordomingo
force-pushed
the
implement-handlers
branch
from
1158d7f to
83592bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially solves #3
supersedes #16
edd1807 Implement
/experimenthandlers