Skip to content

Remove diff column #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2018
Merged

Remove diff column #232

merged 1 commit into from
Mar 27, 2018

Conversation

dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Mar 27, 2018 •
edited
Loading

Diff was no longer needed since #194

The Staging internal database will be migrated with (via #221)

go run cli/migrations/*.go diff-rm-col internal.db

@dpordomingo dpordomingo self-assigned this Mar 27, 2018
@dpordomingo dpordomingo requested review from carlosms and smacker March 27, 2018 16:09
@dpordomingo dpordomingo changed the base branch from master to release/v0.0.8 March 27, 2018 16:09
@dpordomingo dpordomingo added the enhancement Improvements are needed over an existent feature label Mar 27, 2018
@dpordomingo dpordomingo mentioned this pull request Mar 27, 2018
Closed
@dpordomingo dpordomingo changed the title Remove diff Remove diff column Mar 27, 2018
carlosms
carlosms approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpordomingo dpordomingo merged commit 44612a0 into src-d:release/v0.0.8 Mar 27, 2018
@dpordomingo dpordomingo deleted the remove-diff branch March 27, 2018 19:06
This was referenced Apr 4, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@smacker smacker smacker approved these changes

@carlosms carlosms carlosms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dpordomingo dpordomingo

Labels

enhancement Improvements are needed over an existent feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpordomingo @smacker @carlosms