-
Notifications
You must be signed in to change notification settings - Fork 26
Avoid external dependencies #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Travis fails because #230 has not been yet merged |
CI is failing on |
@smacker ptal #231 (comment) |
aaah. I got it! You can't create this PR on top of #230 because that one for another branch. |
6d95366
to
ceb6765
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but I still think it's not a good idea to maintain CI fork inside code-annotation project.
@bzz maybe you also want to take a look |
totally see @smacker point and agree Sorry, I must have missed that, but what was the original reason for having https://github.com/src-d/code-annotation/tree/ci ? |
@bzz since we cannot use
I choose (e) until (c) is unblocked, what would you purpose? |
internal branch (e) is no longer needed since src-d/ci#58 src-d/ci#60 src-d/ci#61 PRs were just merged |
ceb6765
to
bd9e32d
Compare
Depends on
#230src-d/ci#58 src-d/ci#60 src-d/ci#61Use src-d/ci:v1 to avoid external dependencies