Authorization #22
Merged
Authorization #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpordomingo
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
I focused on reviewing the front part, and since it helps you to keep working, LGTM.
I can rearrange the API part once #16 has been approved
Closed
carlosms
reviewed
Jan 19, 2018
server/service/jwt.go
Outdated
| func (j *JWT) MakeToken(user *model.User) (string, error) { | ||
| claims := &jwtClaim{ID: user.ID} | ||
| t := jwt.NewWithClaims(jwt.SigningMethodHS256, claims) | ||
| fmt.Println("skey", j.signingKey) |
|
I only have two comments:
|
carlosms
approved these changes
Jan 19, 2018
|
@carlosms very good points!
|
|
blocked by #16 and structure review. |
dpordomingo
approved these changes
Jan 19, 2018
There was a problem hiding this comment.
I'd not block this PR because of #16
imho this can be merged, and I'll rebase and rework on top of this one. I think it will be better because this functionality is already "completed" from the back to the FE
|
Sounds good, let @smacker finish last few things in here i.e documenting in README how the user should create/provide token \w minimal permissions and set it for a Docker image built locally and then merge this one first. |
bzz
approved these changes
Jan 19, 2018
smacker
force-pushed
the
auth
branch
3 times, most recently
from
ee859c9 to
06506a4
Compare
* OAuth2 with github * JWT * Keep token in local storage * Removed service worker (it catches all locations and I don't see how to override it without create-react-app eject) Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Merging. |
dpordomingo
pushed a commit
that referenced
this pull request
Mar 26, 2018
add node and npm as dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20
to override it without create-react-app eject)
TBD: