Skip to content

Conversation

smacker
Copy link
Contributor

@smacker smacker commented Mar 1, 2018

Implements endpoint for #160

@smacker smacker requested a review from bzz March 1, 2018 13:04
smacker added 2 commits March 1, 2018 15:22
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker mentioned this pull request Mar 1, 2018
5 tasks
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if _, err := io.Copy(tmpfile, file); err != nil {
return nil, fmt.Errorf("can't copy content to tmp db file %s", err)
}
if err := tmpfile.Close(); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n missing

@dpordomingo
Copy link
Contributor

dpordomingo commented Mar 1, 2018

@smacker you can rebase/squash/merge

@smacker smacker merged commit f887212 into src-d:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants