Fe multiple experiments support #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's quite hard to tell but I assume it's 108d583 that needs to be reviewed, would appreciate if you could you please rebase and verify this assumption. Would you mind, in such cases when work is based on many other PRs listing the commits relevant for review if possible? That will speed up the reviews. |
smacker
force-pushed
the
fe_multiple_experiments_support
branch
from
108d583 to
20ce24d
Compare
|
@bzz commit with name |
bzz
approved these changes
Feb 26, 2018
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
smacker
force-pushed
the
fe_multiple_experiments_support
branch
from
20ce24d to
d225a6f
Compare
dpordomingo
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements functionality for #149.
Based on:
#152
#154
#156
Now the list of experiments is default page when user login.
Annotation works fine for experiments with id > 1.
Review link still points on the first experiment though. It's possible to open review for other experiments changing url, but no link. Most probably the experiments list page should be modified and links should be there. After we can remove the one from top bar. But we don't have wireframes for that.