Skip to content

Package windows binaries as zip instead of tar.gz #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
smacker wants to merge 2 commits into
base: v1
Choose a base branch
from
Open

Package windows binaries as zip instead of tar.gz #98

smacker wants to merge 2 commits into from

Conversation

@smacker
Copy link
Contributor

@smacker smacker commented Mar 12, 2019

Fix: #96

@smacker
Package windows binaries as zip instead of tar.gz
fa44c60 
Signed-off-by: Maxim Sukharev <max@smacker.ru>
@carlosms
Copy link
Contributor

carlosms commented Mar 12, 2019

Should we update this example to include the zip file?
https://github.com/src-d/ci/blob/v1/examples/basic/.travis.yml#L39

@smacker
update example .travis.yml with zip archives
f0d50c1 
Signed-off-by: Maxim Sukharev <max@smacker.ru>
@smacker
Copy link
Contributor Author

smacker commented Mar 12, 2019

Thanks Carlos! Fixed in f0d50c1

@smacker
Copy link
Contributor Author

smacker commented Mar 12, 2019

Appveyor is failing unrelated to the changes in PR with error starting RabbitMQ.

carlosms
carlosms approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smola smola requested a review from mcuadros March 19, 2019 12:03
@smacker
Copy link
Contributor Author

smacker commented Mar 28, 2019

friendly ping @mcuadros

@smacker smacker mentioned this pull request Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcuadros mcuadros Awaiting requested review from mcuadros

4 more reviewers

@smola smola smola approved these changes

@carlosms carlosms carlosms approved these changes

@dpordomingo dpordomingo dpordomingo approved these changes

@se7entyse7en se7entyse7en se7entyse7en approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smacker @carlosms @smola @dpordomingo @se7entyse7en