cli: make locking timeout configurable#363
Merged
jfontan merged 3 commits intosrc-d:masterfrom Oct 17, 2018
Merged
Conversation
Signed-off-by: Javi Fontan <jfontan@gmail.com>
ajnavarro
approved these changes
Oct 17, 2018
erizocosmico
approved these changes
Oct 17, 2018
mcarmonaa
approved these changes
Oct 17, 2018
kuba--
reviewed
Oct 17, 2018
| Locking string `long:"locking" env:"BORGES_LOCKING" default:"local:" description:"locking service configuration"` | ||
| LockingTimeout string `long:"locking-timeout" env:"BORGES_LOCKING_TIMEOUT" default:"0" description:"timeout to acquire lock, 0 means no timeout"` | ||
| Workers int `long:"workers" env:"BORGES_WORKERS" default:"1" description:"number of workers, 0 means the same number as processors"` | ||
| Timeout string `long:"timeout" env:"BORGES_TIMEOUT" default:"10h" description:"deadline to process a job"` |
Contributor
Author
There was a problem hiding this comment.
Some repos can take a lot of time. We use smaller values for our deployment.
kuba--
reviewed
Oct 17, 2018
cli/borges/consumer.go
Outdated
| Workers int `long:"workers" env:"BORGES_WORKERS" default:"1" description:"number of workers, 0 means the same number as processors"` | ||
| Timeout string `long:"timeout" env:"BORGES_TIMEOUT" default:"10h" description:"deadline to process a job"` | ||
| Locking string `long:"locking" env:"BORGES_LOCKING" default:"local:" description:"locking service configuration"` | ||
| LockingTimeout string `long:"locking-timeout" env:"BORGES_LOCKING_TIMEOUT" default:"0" description:"timeout to acquire lock, 0 means no timeout"` |
Contributor
There was a problem hiding this comment.
good to say a unit (in seconds)
Contributor
Author
There was a problem hiding this comment.
I've added explanation about units.
kuba--
approved these changes
Oct 17, 2018
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Contributor
Author
|
@smola added a test for locking timeout. Unfortunately the error message does not tell me why it is failing so I have to measure times to be sure that it's failing because that timeout. |
smola
approved these changes
Oct 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.