Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "🚀 Astro v3.3" #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

srbhr
Copy link
Owner

@srbhr srbhr commented Oct 22, 2023

Reverts #15

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-for-resume-matcher 🛑 Canceled (Inspect) Oct 22, 2023 11:13am

@srbhr
Copy link
Owner Author

srbhr commented Oct 22, 2023

@xmok there's a problem with the latest deployment.

Vercel build keep waiting for astro-compress.

image image Need to update those dependencies as well.

@xmok
Copy link
Contributor

xmok commented Oct 23, 2023

Hey srbhr!

Seems odd that the previews are building fine but production build fails 🤔 .

We could remove the astro-compress integration as Astro 3.3. compresses HTML by default. For the other errors like @astro/image, there shouldn't be any references since we're not using that anymore. Is there a reason you're not checking in a *-lock.json file? That might help as well.

Let me know how you'd like to proceed and we'll come up with a new PR.

@srbhr
Copy link
Owner Author

srbhr commented Oct 31, 2023

Yes, we need to find a way to fix this. Let's remove the Astro Compress because as per logs @xmok that's the only thing causing errors.

@xmok
Copy link
Contributor

xmok commented Oct 31, 2023

Check out PR #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants