Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Convert Linkedin job post data to pdf. #84

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

ILB-96
Copy link
Contributor

@ILB-96 ILB-96 commented Jul 30, 2023

Pull Request Title

Linkedin Job Description to pdf file.

Description

You can now insert a url of a job description in Linkedin and it will create a pdf file with the description of the job and put it in the jobDescription folder for you.

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

  • Added a folder that you can use by choice.
  • Added relevant new requirements.

How to Test

  1. run the command: cd linkedin && python create_job_description.py
  2. insert valid url of a linkedin job post in the popup window and press OK

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

Not sure how much this is useful or relevant to the project i am pretty new to contributing but I have more ideas that might be useful:)

@srbhr
Copy link
Owner

srbhr commented Jul 31, 2023

Thanks for this Feature @Hazannovich
Regarding this feature. We had a discussion yesterday. We are going to introduce a FastAPI backend with a React Frontend. So, we might need this code, but in a different place. I will keep this PR open. But I suggest you join in the Discord to keep up with the latest discussions.

Link to discord: https://dsc.gg/resume-matcher

@ILB-96
Copy link
Contributor Author

ILB-96 commented Jul 31, 2023

Thanks for this Feature @Hazannovich Regarding this feature. We had a discussion yesterday. We are going to introduce a FastAPI backend with a React Frontend. So, we might need this code, but in a different place. I will keep this PR open. But I suggest you join in the Discord to keep up with the latest discussions.

Link to discord: https://dsc.gg/resume-matcher

Thanks I joined.
I think I am doing well with react + nextjs + tailwindcss so I will try to help with whatever I can:)

@srbhr
Copy link
Owner

srbhr commented Sep 4, 2023

Hey @Hazannovich can you rebase this PR and resolve the Merge conflict, I'm planning to get this merged along with your other PR and please can you add in the Readme as well how to use this file?

@ILB-96 ILB-96 force-pushed the linkedin_job_url_to_pdf branch from 19e96fe to e7ec5a7 Compare September 8, 2023 18:33
@ILB-96 ILB-96 force-pushed the linkedin_job_url_to_pdf branch from b37008b to c74e73e Compare September 8, 2023 18:36
Copy link
Owner

@srbhr srbhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hazannovich for these changes. I'm merging your PR

@srbhr srbhr merged commit 0551844 into srbhr:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants