Convert HHVM's T_HASHBANG to T_INLINE_HTML (fixes #625) #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHVM 3.5-3.6 tokenize "#!/usr/bin/php" as a non-standard T_HASHBANG instead of PHP5's T_INLINE_HTML, so convert it to the expected T_INLINE_HTML.
|
Bump? |
gsherwood
added a commit
that referenced
this pull request
Sep 14, 2015
|
Thanks for the PR. Sorry it took so long - been a crazy few months. |
legoktm
added a commit
to wikimedia/mediawiki-tools-codesniffer
that referenced
this pull request
Dec 9, 2015
…M >=3.5,<3.7" My upstream patch to address this is included in 2.4.0: <squizlabs/PHP_CodeSniffer#669>. This reverts commit 7cf13be. Change-Id: I7f6806d252e04753e39197d5fad18c52d6000d1f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHVM 3.5-3.6 tokenize "#!/usr/bin/php" as a non-standard T_HASHBANG
instead of PHP5's T_INLINE_HTML, so convert it to the expected
T_INLINE_HTML.