Generic/FunctionCallArgumentSpacing: prevent fixer conflict over PHP 7.3+ trailing comma's in function calls #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7.3+ trailing comma's in function calls As of PHP 7.3, trailing comma's in function calls are allowed. This sniff should leave those alone to prevent fixer conflicts with sniffs dealing with the spacing around the parentheses of a function call, like the `PEAR.Functions.FunctionCallSignature` sniff, which this sniff is often combined with. While the sniff did take trailing comma's into account for multi-line function calls, it did not handle them correctly for single-line function calls. Note: too _much_ space can still be removed, but space should be added. Fixed now. Includes tests.
gsherwood
added a commit
that referenced
this pull request
May 4, 2023
jrfnl
deleted the
feature/generic-functioncallargumentspacing-fix-fixer-conflict-with-php73-trailing-commas
branch
|
Merged manually. |
3 tasks
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported via Mastodon by @WyriHaximus: https://phpc.social/@wyri@haxim.us/110224066521542315
As of PHP 7.3, trailing comma's in function calls are allowed.
This sniff should leave those alone to prevent fixer conflicts with sniffs dealing with the spacing around the parentheses of a function call, like the
PEAR.Functions.FunctionCallSignaturesniff, which this sniff is often combined with.While the sniff did take trailing comma's into account for multi-line function calls, it did not handle them correctly for single-line function calls.
Note: too much space can still be removed, but space should not be added.
Fixed now.
Includes tests.