Generic/[Upper|Lower]CaseConstant: ignore type declarations #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adjusts the `Generic.PHP.UpperCaseConstant` and the `Generic.PHP.LowerCaseConstant` sniffs to ignore property, parameter and return type declarations. Type declarations have their own rules and should not be treated the same as other `false`, `true` and `null` uses. Includes unit tests. Fixes 3332
jrfnl
force-pushed
the
feature/3332-generic-upperlowercaseconstant-ignore-type-declarations
branch
from
022c14c
to
2c4f3cc
Compare
|
Rebased to get a passing build on PHP 8.1. |
gsherwood
added a commit
that referenced
this pull request
Jan 16, 2022
|
Thanks for changing these sniffs. I ended up having upper extend lower to remove much of the duplicate logic and to force these to always be in sync. |
jrfnl
deleted the
feature/3332-generic-upperlowercaseconstant-ignore-type-declarations
branch
Makes sense as these sniffs will (should) never be used within the same standard as they contradict each other. I've become a bit wary of sniffs extending each other after seeing too many problems with that in external standards, but in this case it shouldn't be problematic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the
Generic.PHP.UpperCaseConstantand theGeneric.PHP.LowerCaseConstantsniffs to ignore property, parameter and return type declarations.Type declarations have their own rules and should not be treated the same as other
false,trueandnulluses.Includes unit tests.
Fixes #3332