Generic/InlineControlStructure: ignore while without body #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in issue 2822, this changes the sniff to ignore `while()` and `for` constructs without body. This - partially - undoes the unit tests added for issue 1932, but there are still some remaining covering that issue. Fixes 2822
jrfnl
force-pushed
the
feature/2822-generic-inlinecontrolstructures-bug-fix
branch
from
8e2f481 to
13c803b
Compare
gsherwood
added a commit
that referenced
this pull request
Jan 30, 2020
Member
|
Thanks for fixing this up. I actually had no idea you could have WHILEs and FORs with no body. I guess I just never tried. |
jrfnl
deleted the
feature/2822-generic-inlinecontrolstructures-bug-fix
branch
Contributor
Author
|
I was running some tests and it turns out that even |
tobias-trozowski
pushed a commit
to tobias-trozowski/PHP_CodeSniffer
that referenced
this pull request
Feb 13, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #2822, this changes the sniff to ignore
while()andforconstructs without body.This - partially - undoes the unit tests added for issue #1932, but there are still some remaining covering that issue.
Fixes #2822
Edit: I've updated the PR to now also allow for
forstructures without body. See the accompanied unit test.