Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEAR/FileComment: remove the TLD character limit #2568

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Jul 24, 2019

What with new TLDs being accepted all the time and lots of them being longer then 7 characters, the character limit seems out of date.

Includes unit test.

Fixes #2566

What with new TLDs being accepted all the time and lots of them being longer then 7 characters, the character limit seems out of date.

Includes unit test.

Fixes 2566
@gsherwood gsherwood added this to the 3.5.0 milestone Jul 25, 2019
@gsherwood gsherwood merged commit c7b090a into squizlabs:master Jul 25, 2019
gsherwood added a commit that referenced this pull request Jul 25, 2019
@gsherwood
Copy link
Member

Too quick. Thanks.

@jrfnl jrfnl deleted the feature/2566-pear-filecomment-allow-new-tld-author branch July 25, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author tag email validation doesn't support all TLDs
2 participants