Skip to content

Check if currentDir is readable on loop iteration when initializing Config #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Check if currentDir is readable on loop iteration when initializing Config #2564

merged 1 commit into from
Jul 29, 2019

Conversation

MasterOdin
Copy link
Contributor

Fixes #2549

is_readable will return false if the passed directory falls outside of a set open_basedir php.ini directive, while also raising a warning that is suppressed here. I assume that phpcs is initially run from a directory inside the open_basedir directive. I wasn't sure if/how one might add tests for this.

@gsherwood gsherwood added this to the 3.5.0 milestone Jul 25, 2019
@gsherwood
Copy link
Member

Thanks a lot for this PR. The fix worked great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching for a phpcs.xml file can throw warnings due to open_basedir restrictions
2 participants