Fix issues found by Psalm #2084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found using this Psalm config on
vimeo/psalm:dev-master.Mostly just docblock improvements, with a few changes:
PHP_CodeSniffer\Files\File::getSuccessCountbecause it used an undefined property and seems never to have been calledDOMNodes toDOMElements because the called methods only existed on the subclass.PHP_CodeSniffer\Tokenizers\Tokenizer, one ($numTokens) that's used in different functions and another ($scopeOpeners) that's referenced in that class but only defined in subclasses.