Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Generic/LineLength: add ability to ignore long comment lines completely #1510

Merged
merged 2 commits into from
Aug 31, 2017
Merged

[3.x] Generic/LineLength: add ability to ignore long comment lines completely #1510

merged 2 commits into from
Aug 31, 2017

Commits on Jun 17, 2017

  1. LineLength sniff: add unit tests for existing properties 

    As the sniff uses the `T_OPEN_TAG` token and then walks through the whole file in one go, the properties need to be changed in the test file **_before_** the open tag is encountered.

In practice, this means that the unit tests for the changed properties need to be in separate files.
    @jrfnl
    jrfnl committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    66539a2 View commit details
    Browse the repository at this point in the history

  2. LineLength sniff: add $ignoreComments property 

    As suggested & discussed on twitter: https://twitter.com/MrDanack/status/874631725036523520
    @jrfnl
    jrfnl committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    ca96ed3 View commit details
    Browse the repository at this point in the history